fix(runtime-dom): v-model on checkbox can work with truthy/falsy values (#5775) #5780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
haoqunjiang added need guidance 
Comment on lines +153 to +157
| if (el._trueValue === undefined && el._falseValue === undefined) { | ||
| el.checked = looseEqual(!!value, getCheckboxValue(el, true)) | ||
| } else { | ||
| el.checked = looseEqual(value, getCheckboxValue(el, true)) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (el._trueValue === undefined && el._falseValue === undefined) { | |
| el.checked = looseEqual(!!value, getCheckboxValue(el, true)) | |
| } else { | |
| el.checked = looseEqual(value, getCheckboxValue(el, true)) | |
| } | |
| if ('_trueValue' in el || '_falseValue' in el) { | |
| el.checked = looseEqual(value, getCheckboxValue(el, true)) | |
| } else { | |
| el.checked = !!value | |
| } |
- Using
inrather than=== undefinedwould be more consistent withgetCheckboxValue, allowingundefinedto be used as a value. I've flipped the branches to avoid negating everything. looseEqual(!!value, getCheckboxValue(el, true))simplifies down to just!!valueiftrueValueisn't specified.- On the latest
main,el.checkedhas been replaced with a local variable calledchecked, but otherwise the logic should be the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #5775