dx(script-setup): add generic type to defineExpose #5035
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, the public API for a component defined using
defineExposeis not typed when this component is used elsewhere (as discussed in #4397).My current workaround is to define the API as an interface and casting the object in the component:
MyComponent.d.tsMyComponent.vueBut writing that is cumbersome, I'd prefer doing the following:
So that's what this PR allows :). Given that it's optional, it shouldn't affect people who isn't using this approach.
I tried extracting this pattern into my own method which I called
definePublicAPI, but I was getting a warning so I guessdefineExposecannot be used for composition.