fix(runtime-vapor): component emits vdom interop #13498
Open
+35,541 −2,627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
edison1105 commented Jun 19, 2025
edison1105 commented - Playground with vapor branch
…y watching props (#13384)
edison1105 commented Jun 20, 2025
| @@ -52,7 +52,7 @@ const vaporInteropImpl: Omit< | |||
| const instance = (vnode.component = createComponent( | |||
| vnode.type as any as VaporComponent, | |||
| { | |||
| $: [() => propsRef.value], | |||
| $: extend([() => propsRef.value], { __interop: true }), | |||
There was a problem hiding this comment.
Add __interop flag to the $ to mark props that are passed from vdom component
There was a problem hiding this comment.
- Use a symbol instead of
__interop(which can also be used for other cases if needed) - Directly assign the symbol instead of using
extend
edison1105 force-pushed the edison/fix/emitVdomInterop branch from bb08ce3 to 26dbd3c Compare 
yyx990803 requested changes Jul 3, 2025
| @@ -52,7 +52,7 @@ const vaporInteropImpl: Omit< | |||
| const instance = (vnode.component = createComponent( | |||
| vnode.type as any as VaporComponent, | |||
| { | |||
| $: [() => propsRef.value], | |||
| $: extend([() => propsRef.value], { __interop: true }), | |||
There was a problem hiding this comment.
- Use a symbol instead of
__interop(which can also be used for other cases if needed) - Directly assign the symbol instead of using
extend
yyx990803 reviewed Jul 3, 2025
| @@ -26,7 +26,7 @@ import { renderEffect } from './renderEffect' | |||
| | |||
| export type RawProps = Record<string, () => unknown> & { | |||
| // generated by compiler for :[key]="x" or v-bind="x" | |||
| $?: DynamicPropsSource[] | |||
| $?: DynamicPropsSource[] & { __interop?: boolean } | |||
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.