feat(runtime-vapor): use shallow clone to support shallowRef in v-for #12985
+40 −12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
| Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
Size ReportBundles
Usages
|
edison1105 added the ❗ p4-important 
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
LittleSound reviewed Jul 10, 2025
Comment on lines 419 to 427
| | ||
| // change deep value should not update | ||
| // change | ||
| list.value[0].name = 'a' | ||
| setList() | ||
| await nextTick() | ||
| expect(host.innerHTML).toBe( | ||
| '<li>0. 1</li><li>1. 2</li><li>2. 3</li><li>3. 4</li><!--for-->', | ||
| '<li>0. a</li><li>1. 2</li><li>2. 3</li><li>3. 4</li><!--for-->', | ||
| ) | ||
| |
There was a problem hiding this comment.
This feature was initially removed for performance optimization:
vuejs/vue-vapor#280
vuejs/vue-vapor@b962aa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
REPL
Using the
rows.slice()(shallow copy) to replaced therows, only the content inside v-for hasn't changed, which is inconsistent with the behavior of the Virtual DOM.So I created a shallow clone for the item when the source is a not a reactive object .