Load, render template version using helper #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
LinusBorg approved these changes Dec 27, 2017
| @sudo-suhas That actually doesn't work for me, I just get this:
it correctly reads the version from pkg.json, but apperantly the helper returns nothing for me :/ Edit: ah, got it. You accidentally put the |
LinusBorg added a commit that referenced this pull request Dec 31, 2017
helper function was outside of the helpe object where it would belong
| My bad. I had tested it but must have inadvertently introduced the mistake while rebasing and removing conflicts. Very sorry. |
LinusBorg added a commit that referenced this pull request Dec 31, 2017
* develop: bump template version fix bug with #1202 Make CSS sourcemaps on by default Ensure page reloads in history mode serve index.html use old sourcemap option Add postcss-url to match postcss-import (#1115) Change engine>node{4 => 6} for template (#1206) Fix static file serving for publicPath != `/` (fix#1176) (#1180) Load, render template version using helper (#1202) fix typo in a comment (#1183) fix #1140
| Don't worry, thanks for the continuing contributions :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds a helper to
meta.jsso that the template version intemplate/config/index.jsdoes not need manual maintenance and is instead loaded frompackage.json>version.