Set ExtractTextPlugin.allChunks to true #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…tractTextPlugin.extract) in the commons chunk, allChunks must be set to true https://github.com/webpack-contrib/extract-text-webpack-plugin
| For a quick testing of multiple common chunks, this project may be helpful. |
mgenware changed the title 
| Hey @mgenware , so I looked into this, and I don't think that I want to activate this by default. ReasoningWith the current config, CSS from .vue files that are code-splitted will reside in that async chunk and only be loaded when that async chunk is actually loaded. That means that the SolutionI think this option can be useful though, and so I would suggest to add it to the templates config like this: If you want to make this change to your branch, I will merge this so you get credit for bringing this to our attention.s |
LinusBorg suggested changes Nov 12, 2017
…split chunks (credit to @LinusBorg)
| Hi @LinusBorg, thanks for your informative reply. I totally agree, I've committed changes to my branch 😀 |
LinusBorg approved these changes Nov 12, 2017
c0defre4k added a commit to neonblack-at/webpack that referenced this pull request Nov 17, 2017
* vuejs-templates/master: (54 commits) v1.2.3 remove double FriendlyErrorsPlugin (fix vuejs-templates#1064) v 1.2.2 remove unnecessary minimize option (close vuejs-templates#1056) Make sure that imported css files in SFCs are autoprefixed, too (vuejs-templates#1053) reduce clientLogLevel remove `express` from package.json (vuejs-templates#1060) Remove extra commas (vuejs-templates#1050) 1.2.1 - Bugfix release (vuejs-templates#1052) bumb version string in config in package.json bumb version string in config re-add postcss-loader Fix typos and formatting (vuejs-templates#1048) fix(jest): fix Jest coverage directory (vuejs-templates#1046) Remove unnecessary whitespaces (vuejs-templates#1047) re-merge (vuejs-templates#1045) Set ExtractTextPlugin.allChunks to true (vuejs-templates#1027) pass cssSourceMap option to vue-loader (vuejs-templates#756) Grammar and typo fixes on docs (vuejs-templates#992) Use webpack 3's standard way to generate a manifest in CommonsChunkPlugin (vuejs-templates#1028) ... # Conflicts: # meta.js # template/config/index.js # template/index.html # template/package.json
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this pull request Dec 25, 2017
* When using CommonsChunkPlugin and there are extracted chunks (from ExtractTextPlugin.extract) in the commons chunk, allChunks must be set to true https://github.com/webpack-contrib/extract-text-webpack-plugin * Explicitly set allChunks to false along with some useful info on codesplit chunks (credit to @LinusBorg) * Update webpack.prod.conf.js
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
* When using CommonsChunkPlugin and there are extracted chunks (from ExtractTextPlugin.extract) in the commons chunk, allChunks must be set to true https://github.com/webpack-contrib/extract-text-webpack-plugin * Explicitly set allChunks to false along with some useful info on codesplit chunks (credit to @LinusBorg) * Update webpack.prod.conf.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using CommonsChunkPlugin and there are extracted chunks (from ExtractTextPlugin.extract) in the commons chunk, allChunks must be set to true。
Doc: https://github.com/webpack-contrib/extract-text-webpack-plugin