Skip to content

fix: typing on IconComponent #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix: typing on IconComponent #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bdf5b5
fix: typing on IconComponent
murrple-1 Aug 16, 2024
aa4135a
fixing some type issues with @expo
Aug 21, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/HeaderButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,19 @@ import type { ComponentProps, ReactNode } from 'react';
export type VisibleButtonProps = {
title: string;

IconComponent?: React.ComponentType<{
name: any; // TODO generify to support icon names
style?: any;
color?: ColorValue;
size?: number;
}>;
IconComponent?:
| React.ComponentType<{
name: any; // TODO generify to support icon names
style?: any;
size?: number;
color?: ColorValue;
}>
| React.ComponentType<{
name: any; // TODO generify to support icon names
style?: any;
size?: number;
color?: ColorValue | number;
}>;
iconName?: string;
iconSize?: number;
color?: ColorValue;
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/HeaderButtons.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ describe('HeaderButtons', () => {
const IoniconsHeaderButton = (props: HeaderButtonProps) => (
<HeaderButton
{...props}
IconComponent={({ name }) => <Text>{name}</Text>}
IconComponent={({ name }: { name: any }) => <Text>{name}</Text>}
iconSize={23}
color="blue"
/>
Expand Down