feat: extract HeaderButtonsProviders #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vonovak force-pushed the feat/extract-menu branch from b2e7aeb to 1713b4d Compare vonovak force-pushed the feat/extract-menu branch 2 times, most recently from 39bf118 to cc91326 Compare vonovak force-pushed the feat/extract-menu branch from cc91326 to 228c4e1 Compare vonovak force-pushed the feat/extract-menu branch from 8f34b5e to 4f08758 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There are no new features in this release.
The only new thing is that you can get some small bundle size savings: Please see the new installation instructions, there's a change in the
HeaderButtonsProviders which enables the bundle size savings.I did this mostly as an exercise in figuring out how this could be done. There's a test case that ensures different files are
required based on what Provider you choose.It requires RN 73 with
unstable_enablePackageExportsAlso see this blogspost.
breaking change:
MenuItemexport was removed. If you consumed it, let me know and I'll add it back.closes #226