Skip to content

Topic statistics feature #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Gotham25 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Topic statistics feature #3

Gotham25 wants to merge 4 commits into from

Conversation

@Gotham25
Copy link

@Gotham25 Gotham25 commented Oct 8, 2019 •
edited
Loading

This PR adds below features,

  • Enable consumers retrieval for a given topic
  • Retrieve topics created so far
  • Retrieve all messages that has been sent to queue
  • Added dropped property to messages stating that if it is actually consumed by any consumer or not

This PR closes #2
@coveralls
Copy link

coveralls commented Oct 8, 2019

Pull Request Test Coverage Report for Build 11

  • 7 of 18 (38.89%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.9%) to 87.977%
Changes Missing Coverage Covered Lines Changed/Added Lines %
models/message.js 2 3 66.67%
models/queue.js 2 3 66.67%
services/topic.service.js 1 5 20.0%
services/queue.service.js 1 6 16.67%
Totals Coverage Status
Change from base Build 10: -3.9%
Covered Lines: 252
Relevant Lines: 280
💛 - Coveralls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Gotham25 @coveralls