This repository was archived by the owner on Mar 6, 2024. It is now read-only.
Fix HTTP 400 for CustomizationScript in update_guest_customization_section #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix use of Customization Script in update_guest_customization_section(). If CustomizationScript tag was not present in VM's XML before, then this change puts it into correct place. Otherwise it would result in HTTP 400 Bad Request. Signed-off-by: Konrad Gawda <konrad.gawda.opensource@gmail.com>
| @kgawda, VMware has approved your signed contributor license agreement. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix use of Customization Script in update_guest_customization_section().
Problem:
When adding CustomizationScript tag to a VM's XML that did not include it previously, then the original code would place it as a last tag. As described in Issue #635, Cloud Director requires these tags to be ordered in a specific way. This is why the result is:
This PR modifies location where the CustomizationScript is added to XML request, if it was not present before. It fixes some cases mentioned in Issue #635.