Skip to content

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Nov 18, 2025

Purpose

FAILED entrypoints/openai/test_metrics.py::test_metrics_exist[-multimodal] - openai.InternalServerError: Error code: 500 - {'error': {'message': "403, message='Forbidden', url='https://upload.wikimedia.org/wikipedia/commons/thumb/d/dd/Gfp-wisconsin-madison-the-nature-boardwalk.jpg/2560px-Gfp-wisconsin-madison-the-nature-boardwalk.jpg'", 'type': 'Internal Server Error', 'param': None, 'code': 500}} 

Test Plan

pytest -s -v tests/entrypoints/openai/test_metrics.py::test_metrics_exist[-multimodal] 

Test Result

Test should use image on s3 now.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves a flaky test by replacing a dependency on an external Wikipedia URL with a local asset server. This is a good practice that enhances test reliability. The changes are clear, concise, and correctly implemented. I have no further suggestions for improvement.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 18, 2025 06:06
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 18, 2025
@DarkLight1337 DarkLight1337 merged commit 896e41a into vllm-project:main Nov 18, 2025
19 checks passed
@Isotr0py Isotr0py deleted the replace-wiki-url branch November 18, 2025 08:11
Victor49152 pushed a commit to Victor49152/vllm that referenced this pull request Nov 20, 2025
bigPYJ1151 pushed a commit that referenced this pull request Nov 25, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: jiang1.li <jiang1.li@intel.com>
bringlein pushed a commit to bringlein/vllm that referenced this pull request Nov 26, 2025
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
charlotte12l pushed a commit to charlotte12l/vllm that referenced this pull request Dec 5, 2025
…#28908) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Xingyu Liu <charlotteliu12x@gmail.com>
Zhathw pushed a commit to Zhathw/vllm that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

2 participants