Skip to content

Conversation

@cjackal
Copy link
Contributor

@cjackal cjackal commented Nov 6, 2025

Purpose

Update xgrammar dependency version to 0.1.27. This version fixes the bug that negative floats of the form -0.xxx is not allowed as a valid JSON number field.

There is no API changes on xgrammar side from this bugfix version update, so safe to bump the version.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
Signed-off-by: cjackal <44624812+cjackal@users.noreply.github.com>
@mergify mergify bot added the ci/build label Nov 6, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the xgrammar dependency from version 0.1.25 to 0.1.27. This is a beneficial change as it addresses a known bug related to negative floats in JSON number fields without introducing any API changes. The update improves the robustness of JSON parsing within the system. No critical or high-severity issues were found in this dependency update.

@cjackal
Copy link
Contributor Author

cjackal commented Nov 9, 2025

ping to @mgoin @russellb @aarnphm @benchislett as this version bump is for structured outputs.

@aarnphm aarnphm changed the title Update xgrammar version from 0.1.25 to 0.1.27 [Chore] Update xgrammar version from 0.1.25 to 0.1.27 Nov 9, 2025
@aarnphm aarnphm added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 9, 2025
@cjackal
Copy link
Contributor Author

cjackal commented Nov 10, 2025

The two failed tests seem not related to the version bump.

@russellb russellb enabled auto-merge (squash) November 10, 2025 15:03
@cjackal
Copy link
Contributor Author

cjackal commented Nov 11, 2025

merge main to apply #28413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

3 participants