Skip to content

[BUG] Reorder model config creation #26124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

[BUG] Reorder model config creation #26124

merged 1 commit into from
Oct 3, 2025
+4 −1

Conversation

@ahao-anyscale
Copy link
Contributor

@ahao-anyscale ahao-anyscale commented Oct 2, 2025 •
edited by github-actions bot
Loading

Purpose

Fixes bug with initializing using a s3 source, updates self.model and self.tokenizer so maybe_override_with_speculators does not try to read from s3.

Test Plan

Can start server with s3 url without failing during engine initialization

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.
@ahao-anyscale
reorder model config creation
6a6aaff 
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
@kouroshHakha kouroshHakha added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 2, 2025
@ahao-anyscale ahao-anyscale changed the title reorder model config creation [BUG] Reorder model config creation Oct 2, 2025
@ahao-anyscale ahao-anyscale marked this pull request as ready for review October 2, 2025 19:47
DarkLight1337
DarkLight1337 approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!
@DarkLight1337 DarkLight1337 merged commit c4b48d3 into vllm-project:main Oct 3, 2025
54 checks passed
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
@ahao-anyscale @yewentao256
[BUG] Reorder model config creation (#26124)
d628fa1 
Signed-off-by: ahao-anyscale <ahao@anyscale.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
tomeras91 pushed a commit to tomeras91/vllm that referenced this pull request Oct 6, 2025
@ahao-anyscale @tomeras91
[BUG] Reorder model config creation (vllm-project#26124)
0e13c0a 
Signed-off-by: ahao-anyscale <ahao@anyscale.com> Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
karan pushed a commit to karan/vllm that referenced this pull request Oct 6, 2025
@ahao-anyscale @karan
[BUG] Reorder model config creation (vllm-project#26124)
a0fb166 
Signed-off-by: ahao-anyscale <ahao@anyscale.com> Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
southfreebird pushed a commit to southfreebird/vllm that referenced this pull request Oct 7, 2025
@ahao-anyscale @southfreebird
[BUG] Reorder model config creation (vllm-project#26124)
8a81538 
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
@pwschuurman pwschuurman mentioned this pull request Oct 9, 2025
Closed
1 task
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@ahao-anyscale @xuebwang-amd
[BUG] Reorder model config creation (vllm-project#26124)
e446113 
Signed-off-by: ahao-anyscale <ahao@anyscale.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
@omer-dayan omer-dayan mentioned this pull request Oct 15, 2025
Open
1 task
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
@ahao-anyscale @lywa1998
[BUG] Reorder model config creation (vllm-project#26124)
faa24bd 
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
@ahao-anyscale @alhridoy
[BUG] Reorder model config creation (vllm-project#26124)
2f4b78f 
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@ahao-anyscale @xuebwang-amd
[BUG] Reorder model config creation (vllm-project#26124)
2663c4b 
Signed-off-by: ahao-anyscale <ahao@anyscale.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
@ahao-anyscale @rtourgeman
[BUG] Reorder model config creation (vllm-project#26124)
6b5c53f 
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

3 participants

@ahao-anyscale @DarkLight1337 @kouroshHakha