Skip to content

Conversation

@calvin0327
Copy link
Contributor

@calvin0327 calvin0327 commented Aug 17, 2025

Fix: #23039

From the current code, XPU does not support cudagragh, However, XPUModelRunner is intergrated with GPUModelRuner, and the calcaulation of cudagragh_batch_size in GPUModelRunner is not compatible with XPU.

Purpose

Test Plan

Test Result

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Aug 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue with setting CUDA graph batch sizes on XPU by conditionally initializing cudagraph_batch_sizes only when cudagraph_mode is not NONE. The change is correct for its intended purpose. However, I've identified a critical edge case where an IndexError can occur if CUDA graphs are enabled but no capture sizes are provided, leading to a crash. I've suggested a change to handle this gracefully by disabling CUDA graphs in this scenario and logging a warning.

Signed-off-by: calvin chen <wen.chen@dynamia.ai>
Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@LucasWilkinson LucasWilkinson enabled auto-merge (squash) August 17, 2025 18:44
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 17, 2025
@LucasWilkinson LucasWilkinson merged commit 21e3943 into vllm-project:main Aug 17, 2025
47 checks passed
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
Signed-off-by: calvin chen <wen.chen@dynamia.ai>
cyang49 pushed a commit to cyang49/vllm that referenced this pull request Aug 20, 2025
Signed-off-by: calvin chen <wen.chen@dynamia.ai>
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
Signed-off-by: calvin chen <wen.chen@dynamia.ai> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: calvin chen <wen.chen@dynamia.ai>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: calvin chen <wen.chen@dynamia.ai> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: calvin chen <wen.chen@dynamia.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

2 participants