-
- Notifications
You must be signed in to change notification settings - Fork 11.2k
[Bugfix] Lazy import fused_experts in BitsAndBytesMoEMethod to avoid break not-cuda-alike devices #20822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @bigPYJ1151, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug that prevented the BitsAndBytesMoEMethod from functioning correctly on non-CUDA devices. By converting a global import of a CUDA-specific module into a lazy import, the change ensures broader compatibility and prevents runtime errors on CPU and TPU backends.
Highlights
- Bug Fix for Device Compatibility: Resolved an issue where the
BitsAndBytesMoEMethodwould fail on non-CUDA devices (such as CPU and TPU) due to an eager, global import offused_experts, which is a CUDA-specific module. - Lazy Import Implementation: Refactored the import of
fused_expertsfrom a global scope to a lazy import within theapplymethod ofBitsAndBytesMoEMethod. This ensures the module is only loaded when its functionality is actually invoked, thereby avoiding import errors on incompatible hardware.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review | Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help | Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a bug where a global import of fused_experts caused crashes on non-CUDA devices by lazily importing the module. The change is targeted and resolves the issue.
| logical_to_physical_map: Optional[torch.Tensor] = None, | ||
| logical_replica_count: Optional[torch.Tensor] = None, | ||
| ) -> torch.Tensor: | ||
| from vllm.model_executor.layers.fused_moe import fused_experts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeejeelee left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick fix
| Thank you for fixing it. :) |
yaochengji left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing it!
…break not-cuda-alike devices (vllm-project#20822) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: x22x22 <wadeking@qq.com>
…break not-cuda-alike devices (vllm-project#20822) Signed-off-by: jiang1.li <jiang1.li@intel.com>
…break not-cuda-alike devices (vllm-project#20822) Signed-off-by: jiang1.li <jiang1.li@intel.com>
…break not-cuda-alike devices (vllm-project#20822) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…break not-cuda-alike devices (vllm-project#20822) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…break not-cuda-alike devices (vllm-project#20822) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…break not-cuda-alike devices (vllm-project#20822) Signed-off-by: jiang1.li <jiang1.li@intel.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
BitsAndBytesMoEMethod globally imports
fused_experts, breaks backends like CPU and TPU.Test Plan
Test Result
(Optional) Documentation Update