Skip to content

Fix huggingface-cli[hf-xet] -> huggingface-cli[hf_xet] #15969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

Fix huggingface-cli[hf-xet] -> huggingface-cli[hf_xet] #15969

merged 2 commits into from
Apr 2, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 2, 2025 •
edited by github-actions bot
Loading

Should resolve issues with TPU and ROCm installs.

Alternative to #15963
@hmellor
Fix huggingface-cli[hf-xet] -> huggingface-cli[hf_xet]
5fd7afb 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀
@mergify mergify bot added the ci/build label Apr 2, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) April 2, 2025 20:22
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 2, 2025
@hmellor hmellor mentioned this pull request Apr 2, 2025
Closed
@hmellor
underscore only required for extra deps
1c8346e 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@robertgshaw2-redhat robertgshaw2-redhat merged commit 55acf86 into vllm-project:main Apr 2, 2025
57 of 58 checks passed
@robertgshaw2-redhat robertgshaw2-redhat mentioned this pull request Apr 3, 2025
Merged
@Shafi-Hussain Shafi-Hussain mentioned this pull request Apr 3, 2025
Closed
1 task
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@hmellor @Alex4210987
Fix huggingface-cli[hf-xet] -> huggingface-cli[hf_xet] (vllm-proj…
239ad94 
…ect#15969) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @lulmer
Fix huggingface-cli[hf-xet] -> huggingface-cli[hf_xet] (vllm-proj…
2a3f6fb 
…ect#15969) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
@hmellor hmellor deleted the fix-xet-requirement branch April 24, 2025 16:22
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@hmellor @lk-chen
Fix huggingface-cli[hf-xet] -> huggingface-cli[hf_xet] (vllm-proj…
785a25d 
…ect#15969) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@hmellor @shreyankg
Fix huggingface-cli[hf-xet] -> huggingface-cli[hf_xet] (vllm-proj…
b38abce 
…ect#15969) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Fix huggingface-cli[hf-xet] -> huggingface-cli[hf_xet] (vllm-proj…
26e2205 
…ect#15969) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

3 participants

@hmellor @mgoin @robertgshaw2-redhat