Skip to content

Conversation

@kaixih
Copy link
Contributor

@kaixih kaixih commented Feb 25, 2025

This PR unifies the CUTLASS version to avoid duplication.

@kaixih kaixih requested a review from tlrmchlsmth as a code owner February 25, 2025 19:38
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 25, 2025
@kaixih kaixih force-pushed the kaixih/cutlass_to_3.8 branch from 26f849e to 9e8d068 Compare February 25, 2025 19:39
Copy link

@unchained369 unchained369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cutlass GIT_REPOSITORY https://github.com/nvidia/cutlass.git # Sync with CUTLASS_REVISION variable (e.g., set elsewhere: set(CUTLASS_REVISION "v3.8.0")) GIT_TAG ${CUTLASS_REVISION} # Single dynamic tag GIT_SHALLOW TRUE # Fetch only the tag's commit, no history GIT_PROGRESS TRUE 
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 25, 2025
Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some initializer list changes to compile, but those changes as well as the bump up to 3.8 are already in #13797, which I think we should go ahead and land

@kaixih
Copy link
Contributor Author

kaixih commented Feb 25, 2025

Ah, indeed. We have applied those "initializer list changes" internally to satisfy the compiler. So, maybe we focus on #13797 and close this one?

@kaixih
Copy link
Contributor Author

kaixih commented Feb 25, 2025

Also, I like the idea by @unchained369 to use a unified variable to control the cutlass version.

@tlrmchlsmth
Copy link
Member

tlrmchlsmth commented Feb 25, 2025

Yep, working on getting #13797 through the CI now. I also like the suggestion of a unified variable. If somebody wants to put up a separate PR for that, I'll approve it (especially since this is at least the 2nd time that those lines have diverged)

henrylhtsang and others added 2 commits February 25, 2025 20:54
Signed-off-by: henrylhtsang <henrylhtsang@meta.com>
Signed-off-by: kaixih <kaixih@nvidia.com>
@kaixih kaixih force-pushed the kaixih/cutlass_to_3.8 branch from 9e8d068 to e8904bb Compare February 25, 2025 20:58
@kaixih kaixih changed the title [NVIDIA] Bump up CUTLASS to v3.8.0 [NVIDIA] Unify CUTLASS version in CMakelist.txt Feb 25, 2025
@kaixih
Copy link
Contributor Author

kaixih commented Feb 25, 2025

Repurpose the PR to unify the cutlass version in Cmakefile. Rebased it on #13797. @tlrmchlsmth PTAL.

@mergify
Copy link

mergify bot commented Feb 26, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @kaixih.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 26, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label May 28, 2025
@github-actions
Copy link

This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it. Thank you!

@github-actions github-actions bot closed this Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build needs-rebase ready ONLY add when PR is ready to merge/full CI is needed stale Over 90 days of inactivity

5 participants