Skip to content

[Misc] Log time consumption of sleep and wake-up #13115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

[Misc] Log time consumption of sleep and wake-up #13115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
211320f
Log time consumption of sleep and wake-up.
waltforme Feb 11, 2025
822c780
Move the logging to executor_base.py so V1 can also use it.
waltforme Feb 13, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions vllm/executor/executor_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: Apache-2.0

import asyncio
import time
from abc import ABC, abstractmethod
from typing import (Any, Awaitable, Callable, Dict, List, Optional, Set, Tuple,
Union)
Expand Down Expand Up @@ -200,15 +201,23 @@ def sleep(self, level: int = 1):
if self.is_sleeping:
logger.warning("Executor is already sleeping.")
return
time_before_sleep = time.perf_counter()
self.collective_rpc("sleep", kwargs=dict(level=level))
time_after_sleep = time.perf_counter()
self.is_sleeping = True
logger.info("It took %.6f seconds to fall asleep.",
time_after_sleep - time_before_sleep)

def wake_up(self):
if not self.is_sleeping:
logger.warning("Executor is not sleeping.")
return
time_before_wakeup = time.perf_counter()
self.collective_rpc("wake_up")
time_after_wakeup = time.perf_counter()
self.is_sleeping = False
logger.info("It took %.6f seconds to wake up.",
time_after_wakeup - time_before_wakeup)

def save_sharded_state(
self,
Expand Down