Skip to content

Fix bad path in prometheus example #12481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix bad path in prometheus example #12481

merged 1 commit into from
Jan 28, 2025

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Jan 27, 2025

Found while testing for #12416, just needed to account for the new sub-directory
@mgoin
Fix bad path in prometheus example
a2a86a1 
Signed-off-by: mgoin <michael@neuralmagic.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 27, 2025
@mgoin mgoin merged commit 426a5c3 into vllm-project:main Jan 28, 2025
43 checks passed
tjtanaa pushed a commit to EmbeddedLLM/vllm that referenced this pull request Jan 28, 2025
@mgoin @tjtanaa
Fix bad path in prometheus example (vllm-project#12481)
79151e0 
Signed-off-by: mgoin <michael@neuralmagic.com>
rasmith pushed a commit to rasmith/vllm that referenced this pull request Jan 30, 2025
@mgoin @rasmith
Fix bad path in prometheus example (vllm-project#12481)
043e4d7 
Signed-off-by: mgoin <michael@neuralmagic.com>
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
@mgoin @Isotr0py
Fix bad path in prometheus example (vllm-project#12481)
2d206f6 
Signed-off-by: mgoin <michael@neuralmagic.com> Signed-off-by: Isotr0py <2037008807@qq.com>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
@mgoin @NickLucche
Fix bad path in prometheus example (vllm-project#12481)
b75f460 
Signed-off-by: mgoin <michael@neuralmagic.com>
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
@mgoin @GWS0428
Fix bad path in prometheus example (vllm-project#12481)
5151bd9 
Signed-off-by: mgoin <michael@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

2 participants

@mgoin @njhill