Skip to content

Conversation

@sapphi-red
Copy link
Member

Description

esbuild defaults to classic runtime so the imports are not injected automatically, so this setting was not needed. But rolldown defaults to automatic runtime so this is needed.

fixes vitejs/rolldown-vite#304
requires rolldown/rolldown#5781

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
@sapphi-red sapphi-red added the p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) label Aug 18, 2025
@sapphi-red sapphi-red marked this pull request as draft August 18, 2025 13:43
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@650 
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@650 

commit: cec10e9

@sapphi-red sapphi-red marked this pull request as ready for review August 25, 2025 10:52
@sapphi-red sapphi-red merged commit c4b9878 into main Aug 25, 2025
18 checks passed
@sapphi-red sapphi-red deleted the feat/set-optimizedeps-rolldownoptions-transform-jsx-preserve branch August 25, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)

2 participants