Skip to content

Conversation

brenner8023
Copy link

Description

FIXED: #301

Some vite plugins like unocss:vue-scoped needs to rewrite hmrContext.read to inject their special code into SFC when hmr.

vite-plugin-vue uses fs.readFileSync to get the raw code, but the raw code doesn't have injected code by other plugins.

This PR allows vite-plugin-vue to get transformCode api from other plugins, and then replace fs.readFileSync with readCode function.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
@brenner8023 brenner8023 changed the title fix: hmr got error by transformSFC to inject code (fix #301) fix(plugin-vue): hmr got error by transformSFC to inject code (fix #301) Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant