fix(rsc): keep server stylesheet link for hmr and avoid injecting css via client js #841
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
<link>
and client inline<style>
#677As we've seen in #776, Vite can actually handle css hmr by replacing
<link rel="stylesheet" ... />
https://github.com/vitejs/vite/blob/84079a84ad94de4c1ef4f1bdb2ab448ff2c01196/packages/vite/src/client/client.ts#L200-L201. We've been adding separateimport ".../xxx.css"
via wrapper client jsimporter-resources?rsc-browser
virtual for hmr, but that should be unnecessary.TODO
.module.css?direct
duringhotUpdate
. Also otherwise, it would cause full reload.<link>
and client inline<style>
#677