Skip to content

Conversation

@heavenshell
Copy link
Member

Closes #243

  • Add Gemfile for use octicon pencil.
  • Add license link
  • Fix Deprecation warnings

Top
2018-06-14 22 52 38

Footer
2018-06-14 22 52 44

- Add Gemfile for use `octicon pencil`. - Fix `Deprecation` warnings
@mattn
Copy link
Member

mattn commented Jun 14, 2018

Could you please update assets/images/post-docedit1.png, assets/images/post-docedit2.png ?

/_site/
/target/
/tmp/
Gemfile.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(あれ、これっていいんだっけかな)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore しちゃまずい感じですか?
Ruby 素人なのでよくわかってないので、 https://github.com/vim-jp/vim-jp.github.io/blob/master/.gitignore#L5 これを真似しました!

Copy link
Member

@ujihisa ujihisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemfile.lockのとこ以外はLGTM!

@heavenshell
Copy link
Member Author

@mattn

Could you please update assets/images/post-docedit1.png, assets/images/post-docedit2.png ?

I'll update https://github.com/vim-jp/vim-jp.github.io repo after this PR merged 😉

@mattn
Copy link
Member

mattn commented Jun 15, 2018

Thank you!

@mattn mattn deleted the fix/edit_icon branch June 15, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants