Add Access-Control-Expose-Headers in --cors mode #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
By default, browsers only allow clients to read "CORS-safelisted response headers": https://developer.mozilla.org/en-US/docs/Glossary/CORS-safelisted_response_header However, sometimes it is useful to read other headers that are not safelisted by default, such as `Accept-Ranges`. The `Access-Control-Expose-Headers` header allows controlling which headers are exposed to the client. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Expose-Headers This change exposes all headers when `--cors` is used.
Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
By default, browsers only allow clients to read CORS-safelisted response headers. However, sometimes it is useful to read other headers that are not safelisted by default, such as
Accept-Ranges. TheAccess-Control-Expose-Headersheader allows controlling which headers are exposed to the client.This change exposes all headers (
*) when--corsis used.It could be useful to allow more fine-grained configuration of exposed headers, however, it seems that the existing
--corsmode is a very coarse toggle so I just used*for consistency.I didn't see a relevant place to update docs – is this tool missing documentation for the CLI flags?