Decouple regexes, make varaibles consistent #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #463 +/- ## ========================================== + Coverage 62.62% 62.68% +0.06% ========================================== Files 39 40 +1 Lines 3435 3441 +6 Branches 927 927 ========================================== + Hits 2151 2157 +6 Misses 764 764 Partials 520 520 ☔ View full report in Codecov by Sentry. |
tony force-pushed the split-user-regex branch 2 times, most recently from cb69aae to 00e59ee Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes
RE_USERregex constantsAdd
RE_USERfor URLs that have user in URIRename
SCP_REGEXtoRE_SCPMove to constants
RE_SCPRE_USERRE_PIP_REVAppendix