Fix Array#update(int, T) complexity #2648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
io.vavr.collection.Array#update(int, T) [contains](https://github.com/vavr-io/vavr/blob/2fe989583fee00842e3fc4a5f806b7f2d99a6eba/src/main/java/io/vavr/collection/Array.java#L1507) java.util.Arrays#copyOf(T[], int) call. So it can't be of constant complexity.
Codecov Report
@@ Coverage Diff @@ ## master #2648 +/- ## ============================================ - Coverage 92.89% 92.87% -0.02% Complexity 5368 5368 ============================================ Files 89 89 Lines 12785 12785 Branches 1619 1619 ============================================ - Hits 11876 11874 -2 - Misses 720 722 +2 Partials 189 189
Continue to review full report at Codecov.
|
danieldietrich approved these changes Apr 11, 2021
Contributor
danieldietrich left a comment
danieldietrich left a comment There was a problem hiding this comment.
Many thanks, this looks good.
danieldietrich pushed a commit that referenced this pull request Jul 14, 2021
io.vavr.collection.Array#update(int, T) [contains](https://github.com/vavr-io/vavr/blob/2fe989583fee00842e3fc4a5f806b7f2d99a6eba/src/main/java/io/vavr/collection/Array.java#L1507) java.util.Arrays#copyOf(T[], int) call. So it can't be of constant complexity.
pivovarit pushed a commit that referenced this pull request Aug 20, 2024
io.vavr.collection.Array#update(int, T) [contains](https://github.com/vavr-io/vavr/blob/2fe989583fee00842e3fc4a5f806b7f2d99a6eba/src/main/java/io/vavr/collection/Array.java#L1507) java.util.Arrays#copyOf(T[], int) call. So it can't be of constant complexity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
io.vavr.collection.Array#update(int, T) contains java.util.Arrays#copyOf(T[], int) call. So it can't be of constant complexity.