Fix: CharSeq implements Comparable<CharSeq> #2399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 3 commits March 27, 2019 13:23
class io.vavr.collection.CharSeq cannot be cast to class java.lang.Comparable
class io.vavr.collection.CharSeq cannot be cast to class java.lang.Comparable
Codecov Report
@@ Coverage Diff @@ ## master #2399 +/- ## ========================================= Coverage 95.79% 95.79% Complexity 5427 5427 ========================================= Files 94 94 Lines 13110 13110 Branches 1608 1608 ========================================= Hits 12559 12559 Misses 404 404 Partials 147 147
Continue to review full report at Codecov.
|
danieldietrich suggested changes Mar 27, 2019
Contributor
danieldietrich left a comment
danieldietrich left a comment There was a problem hiding this comment.
Hi Theodor!
Many thanks :-)
Please find my review comments.
Greets,
Daniel
…arSeq as java.lang.Comparator. This commit concerns the issue #2382.
Contributor
| Many thanks!! :) |
danieldietrich approved these changes Mar 31, 2019
danieldietrich changed the title danieldietrich changed the title danieldietrich pushed a commit that referenced this pull request Jul 22, 2019
* [Fix][Bug][2382] java.lang.ClassCastException: class io.vavr.collection.CharSeq cannot be cast to class java.lang.Comparable * [Fix][Bug][2382] java.lang.ClassCastException: class io.vavr.collection.CharSeq cannot be cast to class java.lang.Comparable * Added a test case for the bug fix #2382. * Added less, greater and less test case for testing the behavior of CharSeq as java.lang.Comparator. This commit concerns the issue #2382.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed the bug #2382