Skip to content

Conversation

MahdiBM
Copy link
Collaborator

@MahdiBM MahdiBM commented Jul 12, 2023

@0xTim
Copy link
Member

0xTim commented Jul 17, 2023

@MahdiBM can you update the PR to match apple/swift-openapi-generator#120

@MahdiBM
Copy link
Collaborator Author

MahdiBM commented Jul 18, 2023

Is it worth doing anymore, considering this library is quite small?
I'm thinking of just dropping the PR.

@0xTim
Copy link
Member

0xTim commented Jul 20, 2023

If it's causing warnings in 5.9 we should fix them, but I'm happy for you to close it if it's not worth it

@MahdiBM
Copy link
Collaborator Author

MahdiBM commented Jul 20, 2023

I doesn't cause warnings for other libraries.

The reason the generator used to cause errors for other libraries that have the flag enabled, was that the generator inserts its own generated code into other libraries. So the generated code is part of the other libraries from Swift compiler POV, and if it isn't ExistentialAny compatible, there would be an error.

It's a hard decision but considering @czechboy0 didn't even mention these two server-transport libraries (alongside the Hummingbird one) in his request in the first place anyway, i'll just close the PR.
I'll see what i can do with the Hummingbird library considering that's already merged.

@MahdiBM MahdiBM closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants