Don't log misleading errors when the client closes a connection #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…misleading error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #585 +/- ## ========================================== + Coverage 62.44% 62.45% +0.01% ========================================== Files 132 132 Lines 10472 10476 +4 ========================================== + Hits 6539 6543 +4 Misses 3933 3933
🚀 New features to boost your workflow:
|
fabianfett approved these changes Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, we unconditionally include
.clientClosedConnectionerrors in the logging for connection closure. Even though this is adebug-level log, this error is unnecessarily noisy and potentially misleading, since nothing has actually gone wrong. This PR no longer includes.clientClosedConnectionerrors in the log metadata for normal connection termination.