Correctly place the SSL channel handler in front of the PostgresChannelHandler #527
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ensure that
NIOSSLClientHandler
is added immediately beforePostgresChannelHandler
instead of at the front of the entire pipeline.This ensures that TLS works correctly when working with preexisting channels, such as tunneling connections with
NIOSSH
. See also #526 .Thanks to @Joannis and @gwynne for finding the problem and pointing me to the right place to fix it.