Skip to content

Conversation

@Alexsandruss
Copy link
Contributor

@Alexsandruss Alexsandruss commented Aug 14, 2025

Description

Deselect test_pca_dtype_preservation for sklearn 1.4 which fails on one of CI systems due to difference of PCA solver selection rules and test conditions.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

N/A

@Alexsandruss Alexsandruss added the testing Tests for sklearnex/daal4py/onedal4py & patching sklearn label Aug 14, 2025
@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 80.80% <ø> (+0.08%) ⬆️
github 73.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@Alexsandruss
Copy link
Contributor Author

/intelci: run

Copy link
Contributor

@icfaust icfaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be put under the public: section with a more in depth explanation.

@icfaust icfaust mentioned this pull request Aug 17, 2025
13 tasks
@Alexsandruss Alexsandruss requested a review from icfaust August 18, 2025 09:01
@Alexsandruss Alexsandruss dismissed icfaust’s stale review August 19, 2025 15:30

Comments were addressed.

@Alexsandruss Alexsandruss merged commit d670653 into uxlfoundation:main Aug 19, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Tests for sklearnex/daal4py/onedal4py & patching sklearn

3 participants