Skip to content

Conversation

@david-cortes-intel
Copy link
Contributor

@david-cortes-intel david-cortes-intel commented Aug 1, 2025

Description

This PR makes the step that installs dependencies in the doc CI error out if the calls to pip install fail, so that it would catch errors like these earlier on:
https://dev.azure.com/daal/daal4py/_build/results?buildId=50005&view=logs&j=7e620c85-24a8-5ffa-8b1f-642bc9b1fc36&t=2febcae8-7f6a-51bb-45aa-d6e72c9ea7e2


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
@david-cortes-intel david-cortes-intel changed the title [Experiment, do NOT merge] Set -e mode in doc CI to catch errors MAINT: Set -e mode in doc CI to catch errors Aug 1, 2025
@david-cortes-intel david-cortes-intel marked this pull request as ready for review August 1, 2025 10:47
@david-cortes-intel david-cortes-intel merged commit a2a4369 into uxlfoundation:main Aug 1, 2025
16 of 18 checks passed
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
github 73.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants