Skip to content

Conversation

@CedNaru
Copy link
Member

@CedNaru CedNaru commented Sep 22, 2025

No description provided.

@CedNaru CedNaru requested review from Copilot and piiertho September 22, 2025 03:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes missing vararg argument forwarding in string convenience methods. The changes ensure that variadic arguments (vararg args) are properly spread using the *args operator when calling the underlying methods.

  • Fixed 11 method implementations that were missing the *args spread operator
  • Updated the code generator to automatically include *args for vararg methods

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Object.kt Fixed missing *args in emitSignal, call, and callDeferred methods
TreeItem.kt Fixed missing *args in callRecursive method
SceneTree.kt Fixed missing *args in callGroupFlags and callGroup methods
Node.kt Fixed missing *args in rpc, rpcId, callDeferredThreadGroup, and callThreadSafe methods
ClassDB.kt Fixed missing *args in classCallStatic method
MethodRule.kt Updated code generator to automatically append *args for vararg methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@CedNaru CedNaru linked an issue Sep 22, 2025 that may be closed by this pull request
@CedNaru CedNaru merged commit d0c9d5b into master Sep 28, 2025
70 checks passed
@CedNaru CedNaru deleted the fix/string-only-vararg-generation branch September 28, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants