Skip to content

Conversation

viniciusam
Copy link
Member

Fixes #50 #42

@jgebal jgebal requested a review from pesse February 26, 2020 22:50
@jgebal
Copy link
Member

jgebal commented Apr 6, 2020

@pesse - any chance for you to review this PR?

- mvn org.jacoco:jacoco-maven-plugin:prepare-agent test
- mvn test
- echo "Run Integration Tests"
- mvn org.jacoco:jacoco-maven-plugin:prepare-agent verify -Pintegration -DdbUser="${DB_UT3_USER}" -DdbPass="${DB_UT3_PASS}" -DdbUrl="jdbc:oracle:thin:@${DB_URL}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is why we have no coverage on project anymore.
Any reason why jacoco was removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't removed, it was added in the pom as a build step:
https://github.com/utPLSQL/utPLSQL-maven-plugin/blob/release/3.1.3/pom.xml#L252
https://github.com/utPLSQL/utPLSQL-maven-plugin/blob/release/3.1.3/pom.xml#L400

I remember testing this, I will need to take another look.

@jgebal
Copy link
Member

jgebal commented Apr 6, 2020

@jgebal
Copy link
Member

jgebal commented Apr 7, 2020

It seems that coverage is not getting gathered on pull requests or something...

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2020

@jgebal
Copy link
Member

jgebal commented Apr 8, 2020

I ran the MVN in debug mode.
Jacoco sonar import cannot find any Jacoco reports for some reason.

[INFO] 00:17:16.784 Sensor HTML [web] (done) | time=6ms [INFO] 00:17:16.784 Sensor JaCoCo XML Report Importer [jacoco] [DEBUG] 00:17:16.788 No reports found [INFO] 00:17:16.788 Sensor JaCoCo XML Report Importer [jacoco] (done) | time=4ms [INFO] 00:17:16.788 Sensor ThymeLeaf template sensor [securityjavafrontend] [INFO] 00:17:16.789 Sensor ThymeLeaf template sensor [securityjavafrontend] (don 

Full raw build log here:
https://api.travis-ci.org/v3/job/672308796/log.txt
or here:
https://travis-ci.org/github/utPLSQL/utPLSQL-maven-plugin/builds/672308795

@jgebal
Copy link
Member

jgebal commented Apr 9, 2020

There is a lot of valuable code here.
I don't want lack of coverage report to be a blocker for merging this.
@pesse - We can merge this if you're OK.
Jacoco reporting on the project can be solved post-release - what do you think?

@pesse
Copy link
Member

pesse commented Apr 9, 2020

Yes, sure. I will try to get it running in a test setup, but current times are not that side-hobby friendly 😉

@viniciusam
Copy link
Member Author

Thanks, I'm gonna merge it then. I have a branch with some code refactoring, so I might get the coverage up on that.

@viniciusam viniciusam merged commit 703824d into develop Apr 10, 2020
@simasch simasch deleted the release/3.1.3 branch November 19, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants