Skip to content

Adds support of custom type parameters (#5) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2018
Merged

Adds support of custom type parameters (#5) #16

merged 2 commits into from
Jun 7, 2018

Conversation

jgarec
Copy link
Contributor

@jgarec jgarec commented May 29, 2018

  • Adds new parameters : sourcesCustomTypeMapping &
    testsCustomTypeMapping
  • Adds one new sample project
@jgarec
Adds support of custom type parameters (utPLSQL#5)
a2c357f 
* Adds new parameters : sourcesCustomTypeMapping & testsCustomTypeMapping * Adds one new sample project
@jgarec
Copy link
Contributor Author

jgarec commented May 29, 2018

Here's an example of the new parameters :

 <sourcesCustomTypeMapping> <customTypeMapping> <type>package body</type> <customMapping>package_bodies</customMapping> </customTypeMapping> </sourcesCustomTypeMapping>

where sourcesCustomTypeMapping contains a list of customTypeMapping
jgebal
jgebal reviewed May 29, 2018
View reviewed changes
Copy link
Member

@jgebal jgebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments I've added are more generic. Not direcly related to the PR itself.
I've just spottrd those 2 things while looking at the code.
utplsql-maven-plugin/src/test/resources/type-mapping-project/pom.xml Outdated
</includes>
</test>
</tests>
<testsRegexExpression>.*(\\|\/)(\w+)(\\|\/)(\w+)(\\|\/)(\w+).(\w{3})</testsRegexExpression>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wirh utPLSQL v3.1 the regex can be of a simplified form. See doc.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you point the documentation about this ? :)
I need to use the "owner" parameter ?
utplsql-maven-plugin/src/test/resources/type-mapping-project/pom.xml

<ignoreFailure>false</ignoreFailure>

<paths>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change from paths to suitepaths? paths seem too ambiguous and not self-descriptive enough.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed in #17
@jgarec jgarec mentioned this pull request May 30, 2018
Closed
jgebal
jgebal approved these changes Jun 6, 2018
View reviewed changes
Copy link
Member

@jgebal jgebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
@jgebal
Copy link
Member

jgebal commented Jun 6, 2018

@alberto-hernandez , @pesse
Are you OK with merging this PR?
@pesse
Copy link
Member

pesse commented Jun 6, 2018

Looks like great work. One thing about test showcase: wouldn't it be better/more consistent to integrate that into demo-project and link to that?
I like the package pretty much and it would be a great benefit to have it available for several modules
@alberto-hernandez alberto-hernandez merged commit 93abf66 into utPLSQL:develop Jun 7, 2018
@alberto-hernandez
Copy link
Contributor

Great Work!
@jgarec jgarec mentioned this pull request Jul 16, 2018
Closed
@jgarec jgarec deleted the feature/add_type_mapping_params branch August 2, 2018 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@jgarec @jgebal @pesse @alberto-hernandez