Skip to content

Conversation

bhongy
Copy link
Contributor

@bhongy bhongy commented Feb 17, 2023

No description provided.

@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
venice ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 3:35PM (UTC)
@@ -1,202 +0,0 @@
import {useAtom} from 'jotai'
Copy link
Contributor Author

@bhongy bhongy Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused. Delete to allow us to replace the old @usevenice/ui/Tabs with the ones updated with the current design.

options: Array<{key: K; label: string}>
}

export function PrimaryTabs<K extends string>(props: PrimaryTabsProps<K>) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This becomes TabsTriggers via @usevenice/ui

options: Array<{key: OutputTabsKey; label: string}>
}

function OutputFormatTabs(props: OutputFormatTabsProps) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate

@@ -1,16 +0,0 @@
import {DialogPrimitive as Dialog} from '@usevenice/ui'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,24 +0,0 @@
import {DialogPrimitive as Dialog} from '@usevenice/ui'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +19 to +20
await new Promise((resolve) => setTimeout(resolve, 2000))
console.log('Successfully update password', data)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonyxiao I think we need an API for this. Seems like supabase only has reset password via Email flow. https://supabase.com/docs/reference/javascript/auth-resetpasswordforemail

@iwasrobbed should we change to that flow instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please change to whatever is easiest (& we can even punt on this one for now and just ask people to logout if they need to reset pw for some reason)

Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick win 🚀

@iwasrobbed iwasrobbed merged commit d684d60 into staging Feb 17, 2023
@iwasrobbed iwasrobbed deleted the feature/account-page-redesign branch February 17, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants