- Notifications
You must be signed in to change notification settings - Fork 11
feature: Account page redesign #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -1,202 +0,0 @@ | |||
import {useAtom} from 'jotai' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused. Delete to allow us to replace the old @usevenice/ui/Tabs
with the ones updated with the current design.
options: Array<{key: K; label: string}> | ||
} | ||
| ||
export function PrimaryTabs<K extends string>(props: PrimaryTabsProps<K>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This becomes TabsTriggers
via @usevenice/ui
options: Array<{key: OutputTabsKey; label: string}> | ||
} | ||
| ||
function OutputFormatTabs(props: OutputFormatTabsProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate
@@ -1,16 +0,0 @@ | |||
import {DialogPrimitive as Dialog} from '@usevenice/ui' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,24 +0,0 @@ | |||
import {DialogPrimitive as Dialog} from '@usevenice/ui' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await new Promise((resolve) => setTimeout(resolve, 2000)) | ||
console.log('Successfully update password', data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonyxiao I think we need an API for this. Seems like supabase only has reset password via Email flow. https://supabase.com/docs/reference/javascript/auth-resetpasswordforemail
@iwasrobbed should we change to that flow instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please change to whatever is easiest (& we can even punt on this one for now and just ask people to logout if they need to reset pw for some reason)
We can punt on this for now since they have a way to reset pw when logged out already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick win 🚀
No description provided.