Fix API key recognition issue due to Node.js header normalization #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…p module lowercasing HTTP headers.
Collaborator
| Can you not connect using these headers? We already check both lowercase and mixed case versions just in case |
| Has this issue not been officially resolved yet? |
Collaborator
| This is not a general known issue. Most users can use their api keys without an issue. The issue might be something else that we are not aware of. |
Collaborator
| Closing since this is not the actual issue and we will migrate to express on this pr #861 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #716 - API keys were not being recognized because Node.js http
module automatically lowercases all incoming HTTP header names, but the
code was checking for mixed-case headers.