Skip to content

Conversation

@stacquet
Copy link
Contributor

@stacquet stacquet commented Jan 7, 2025

Exceptions were not catched, so possibly, if 9 999 rows were geocoded but 1 fails, the SQL Query broke and all the rows were lost. Change is that the exception is return as text in the sql result

Exceptions were not catched, so possibly, if 9 999 rows were geocoded but 1 fail, the SQL Query broke and all the rows were lost. Change is that the exception is return as text in the sql result
@unytics
Copy link
Owner

unytics commented Jan 9, 2025

Thanks @stacquet for this PR.

I merge it and add an improvement over your suggestion:
-> return a json with an error message when there is an error instead of a plain text

@unytics unytics merged commit 9ca0a21 into unytics:main Jan 9, 2025
@unytics
Copy link
Owner

unytics commented Jan 9, 2025

Thanjs @stacquet, your fix is now updated and deployed. Here is the new function code.

Thanks a lot for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants