Skip to content

Conversation

occidens
Copy link
Contributor

@occidens occidens commented Nov 3, 2022

Description

Two additional git-fzf-* scripts were missing the has function. (See #210).

Type of changes

  • Add/update a helper script or git alias
  • Add/update link to an external resource like a blog post or video
  • Text cleanups/updates
  • Test updates

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Checklist

  • I have read the CONTRIBUTING document.
  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
  • Scripts added/updated in this PR are all marked executable.
  • Scripts added/updated in this PR do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have added a credit line to README.md for any new scripts.
  • If there was no author credit inside a script added in this PR, I have added one.
  • I have confirmed that the link(s) in my PR are valid.
Signed-off-by: William West <occidens@gmail.com>
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 71db557 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@unixorn unixorn merged commit af9af12 into unixorn:main Nov 4, 2022
@unixorn
Copy link
Owner

unixorn commented Nov 4, 2022

Thanks. I'm not sure how I missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants