Skip to content

Conversation

Mo-Gul
Copy link
Contributor

@Mo-Gul Mo-Gul commented Oct 15, 2021

Description

Everything is said in the title.

Type of changes

  • A helper script
  • A link to an external resource like a blog post or video
  • Text cleanups/updates

Checklist:

  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an ok exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have added a credit line to README.md for the script
  • If there was no author credit in a script added in this PR, I have added one.
  • I have confirmed that the link(s) in my PR are valid.
  • I have read the CONTRIBUTING document.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.
Signed-off-by: Stefan Pinnow <Mo-Gul@gmx.net>
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 9d22bab and detected 0 issues on this pull request.

View more on Code Climate.

@unixorn
Copy link
Owner

unixorn commented Oct 16, 2021

Good catch, thanks

@unixorn unixorn merged commit 5ddfbba into unixorn:master Oct 16, 2021
@Mo-Gul Mo-Gul deleted the patch-1 branch October 16, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants