Support smb mounting on linux #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| @yairf-s1, thanks for this PR. To be honest, since I've been working on this project I haven't looked at any of the code in admin.py and I've only looked a little at package.py, which uses admin.py. I'm really happy you submitted this, but I'm going to have to figure out how the code works so I can set up some sort of test before I merge it. |
Collaborator
| I tried to undo a messed up git push I did, and I ended up undoing the merge, so I added it back manually with a new commit. I'm still learning git... |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
solves #71