Remove soft hyphen special case #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Manishearth approved these changes May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Unicode unambiguously specifies that U+00AD SOFT HYPHEN, as a
Default_Ignorable_Code_Point, should have no visible display by default. However, many terminal emulators do not implement the Unicode semantics, but instead implement the ISO Latin-1 semantics, which give the character a visible display (https://unicode.org/faq/casemap_charprop.html#18, https://archive.is/fCT3c).Currently, this library implements the ISO Latin 1 semantics. This PR would switch to the Unicode semantics. Whether it should be merged, depends on what this purpose of this library is supposed to be.