- Notifications
You must be signed in to change notification settings - Fork 809
Adds documentation about name templates in grid editors #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If umbraco/Umbraco-CMS#6634 gets merged, this PR adds documentation for the feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @skttl 😄 Thanks!
About the versioning - the YAML tags..
Shouldn't we instead make a new article for this version? 🤔
So, have the original content in a files called index-v7.md - and this file should have the versionFrom: 7.0.0 tag.
And then this index.md article should have versionFrom: 8.3.0.
I'd be happy to make the versioned articles as well - just let me know! 😁
| We probably should, wasn't sure how it is organized :) |
| No worries 😄 |
| We're closing down Hacktoberfest, so just wanted to let you know, that I've added the label to your PR 😁 Of we can't merge until Umbraco 8.3 is released, so won't do more with it today. |
| This change has been moved to 8.4, FYI 😉 |
| @skttl - I'm having a hard time figuring out if this one was added to the Umbraco 8.4 release, that went live yesterday. |
| umbraco/Umbraco-CMS#6633 This is the change, it is in 8.4. |
| Ah, great, thanks @jmayntzhusen ! 😄 @skttl - should I take care of fixing the versioning, or would you be up for it? 😁 |
| Changed, and I can double verify that the change is in 8.4 - just tried it out for my new version of DTGE :) |
| Ah, I actually meant making separate articles, so we keep the one for Umbraco 7! Would you be up for renaming the old article to index-v7.md with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skttl , I've added some minor adjustments:
- Changed the
versionFromlabel to 7.0.0 again and - Formatted the changes to a tip
Why? Because that way the article will still apply to Umbraco 7, with the addition of the tip for Umbraco 8.4.
Let me know what you think!
...ng-Started/Backoffice/Property-Editors/Built-in-Property-Editors/Grid-Layout/Grid-Editors.md Outdated Show resolved Hide resolved
...ng-Started/Backoffice/Property-Editors/Built-in-Property-Editors/Grid-Layout/Grid-Editors.md Outdated Show resolved Hide resolved
...ng-Started/Backoffice/Property-Editors/Built-in-Property-Editors/Grid-Layout/Grid-Editors.md Show resolved Hide resolved
| Much better :) I think the version should be 7.2.0 as that is the version that introduced grid. |
| Ah, good point @skttl 😁 Would you mind committing the suggestions? |
| @skttl , the PR for Core has been merged and released, right? Do you have time to commit the suggestions I've made to your PR here? |
…Editors/Grid-Layout/Grid-Editors.md Co-Authored-By: sofietoft <stk@umbraco.com>
…Editors/Grid-Layout/Grid-Editors.md Co-Authored-By: sofietoft <stk@umbraco.com>
…Editors/Grid-Layout/Grid-Editors.md Co-Authored-By: sofietoft <stk@umbraco.com>
| Sorry :) |
| No worries at all @skttl ! 😄 |
If umbraco/Umbraco-CMS#6634 gets merged, this PR adds documentation for the feature.