Skip to content

Conversation

@skttl
Copy link
Contributor

@skttl skttl commented Oct 22, 2019

If umbraco/Umbraco-CMS#6634 gets merged, this PR adds documentation for the feature.

If umbraco/Umbraco-CMS#6634 gets merged, this PR adds documentation for the feature.
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @skttl 😄 Thanks!

About the versioning - the YAML tags..
Shouldn't we instead make a new article for this version? 🤔
So, have the original content in a files called index-v7.md - and this file should have the versionFrom: 7.0.0 tag.
And then this index.md article should have versionFrom: 8.3.0.

I'd be happy to make the versioned articles as well - just let me know! 😁

@skttl
Copy link
Contributor Author

skttl commented Oct 23, 2019

We probably should, wasn't sure how it is organized :)

@sofietoft
Copy link
Contributor

No worries 😄
It's not the most intuitive versioning system we've set up, but it does the trick 💪

@sofietoft
Copy link
Contributor

We're closing down Hacktoberfest, so just wanted to let you know, that I've added the label to your PR 😁

Of we can't merge until Umbraco 8.3 is released, so won't do more with it today.
Oh, and would you be willing to make the versioning changes we talked about? I'll be happy to do it as well of course - would just be nice to have it all in one PR if possible.
Do let me know 😁

@jmayntzhusen
Copy link
Contributor

This change has been moved to 8.4, FYI 😉

@sofietoft
Copy link
Contributor

@skttl - I'm having a hard time figuring out if this one was added to the Umbraco 8.4 release, that went live yesterday.
Would you be able to help me out? 😅

@jmayntzhusen
Copy link
Contributor

umbraco/Umbraco-CMS#6633 This is the change, it is in 8.4.
I know because @skttl showed it at last nights meetup 😄

@sofietoft
Copy link
Contributor

Ah, great, thanks @jmayntzhusen ! 😄

@skttl - should I take care of fixing the versioning, or would you be up for it? 😁

@skttl
Copy link
Contributor Author

skttl commented Dec 11, 2019

Changed, and I can double verify that the change is in 8.4 - just tried it out for my new version of DTGE :)

@sofietoft
Copy link
Contributor

Ah, I actually meant making separate articles, so we keep the one for Umbraco 7!
Sorry, that's my bad for not being clear about it 🙈

Would you be up for renaming the old article to index-v7.md with versionFrom: 7.0.0, and then creating a new index.md file with versionFrom: 8.0.0 plus the new lines you're adding here?

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skttl , I've added some minor adjustments:

  • Changed the versionFrom label to 7.0.0 again and
  • Formatted the changes to a tip

Why? Because that way the article will still apply to Umbraco 7, with the addition of the tip for Umbraco 8.4.
Let me know what you think!

@skttl
Copy link
Contributor Author

skttl commented Dec 17, 2019

Much better :)

I think the version should be 7.2.0 as that is the version that introduced grid.

@sofietoft
Copy link
Contributor

Ah, good point @skttl 😁
It's been updated.

Would you mind committing the suggestions?
I don't have permission to do it 😅

@sofietoft
Copy link
Contributor

@skttl , the PR for Core has been merged and released, right?

Do you have time to commit the suggestions I've made to your PR here?
It's OK if you don't, then I'll make the changes myself 😄
Just let me know. Thanks!

skttl and others added 3 commits February 3, 2020 20:07
…Editors/Grid-Layout/Grid-Editors.md Co-Authored-By: sofietoft <stk@umbraco.com>
…Editors/Grid-Layout/Grid-Editors.md Co-Authored-By: sofietoft <stk@umbraco.com>
…Editors/Grid-Layout/Grid-Editors.md Co-Authored-By: sofietoft <stk@umbraco.com>
@skttl
Copy link
Contributor Author

skttl commented Feb 3, 2020

Sorry :)

@sofietoft
Copy link
Contributor

No worries at all @skttl ! 😄
Thanks. I'll get this merged 💪

@sofietoft sofietoft merged commit edacf8c into umbraco:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment