Build pipeline #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Tested the pipeline work that @KevinJump had started in #1. Ran into a few issues when testing that has been fixed in this PR instead.
These changes builds successfully and I also dragged the package into a fresh Umbraco install and it works there 🙂
Link to build: https://github.com/jmayntzhusen/UI-Examples/actions/runs/501344040
One thing to consider is where we want the package.xml file we use for UmbPack stuff. I placed it in the root for now, but can be moved - just have to verify all paths work if we do 🙂