Bugfix: coref must be loaded also from empty nodes #77
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc.nodesiterates only over overt nodes, which results in no coreference information loaded for empty nodes.This fixes it, as iteration over
doc.nodesis replaced with an iteration overdoc.treesand a nested iteration overtree.descendants_and_empty. Another way to fix it is to introduce a method of theDocumentclass that would do the same.I have replaced it in two places to ensure that the following actions are performed even for the empty nodes:
load_coref_from_misc: ensures that coreference is loaded from MISCstore_coref_to_misc: ensures that previous coreference-related MISC features are deleted before writing the new ones