Further speedup (loading: 7.4s -> 3.8s) #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When using Udapi via udapy, gc is disabled by default. But even when gc is not globally disabled, we can get a big speedup: - temporarily disabling garbage collection during CoNLL-U (or another reader) loading - run gc.collect() after the loading is done (all-generation GC after loading makes future node.create_child() calls faster)
- `for i in range(1,10)` is slower than `for i in [1,2,3,4,5,6,7,8,9]`. - We need just some of the columns to be converted.
at the cost of 17% more memory and an additional method `read_trees()` as an alternative to `read_tree()` (which needs to be implemented in all readers anyway)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.