If resegment=False, the root.text should not contain only the first sentence #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ole text, not just the first sentence after segmentation
| Thanks. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Calling
tokenize_tag_parse_treewithresegment=Falsefirst runs the underlying UDPipe, resulting in a sequence of tokens potentially grouped to sentence segments. The nested sequence is then flatten so that all tokens belong to the same segment. However, this was not reflected in theroot.textattribute, which was always assigned a value from UDPipe by callingufal.udpipe.Sentence.getText(). Apparently, instead of recomputing the return value on the fly, the getter returns a value pre-computed during processing.If we do not want the text to be resegmented, the value of
root.textmust stay the same.