Rename cluster to entity #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There is no need to iterate over all bundles/trees/nodes if a given block overrides only process_coref_entity(). Also, the detection of "No processing activity defined in block" had to be adapted to the new methods process_coref_entity and process_coref_mention. TODO: benchmark if calling process_node directly from process_document is actually faster than calling it via process_bundle and process_tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
CorefCluster->CorefEntitymention.cluster->mention.entitycluster.cluster_id->entity.eidcluster.cluster_type->entity.etypefor cluster in doc.coref_clusters.values():->for entity in doc.coref_entities:for cluster_id, cluster in data.coref_clusters.items():->for eid, entity in doc.eid_to_entity:process_coref_mentionandprocess_coref_entity