Skip to content

remove redundant files in dist/ after build #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenns29 merged 1 commit into from
Jan 7, 2023
Merged

remove redundant files in dist/ after build #1469

kenns29 merged 1 commit into from
Jan 7, 2023

Conversation

@kenns29
Copy link
Contributor

@kenns29 kenns29 commented Jan 7, 2023

No description provided.

@kenns29 kenns29 requested a review from austingreco January 7, 2023 03:30
@kenns29 kenns29 merged commit 1d4b74a into master Jan 7, 2023
@kenns29 kenns29 deleted the build branch January 7, 2023 03:34
@spencercharestpaypal
Copy link

spencercharestpaypal commented Jan 9, 2023

@kenns29 it appears this PR has broken imports in 1.11.11. It looks to me like either the build file dist/dist.min.js should be renamed to dist/index.js or that package.json main field should be updated to dist/dist.min.js. main is currently pointing to dist/index.js which no longer exists. Is there anyway you could resolve this for 1.11.12? Let me know if you'd like me to file an issue instead.
@spencercharestpaypal spencercharestpaypal mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@kenns29 @spencercharestpaypal