Skip to content

Conversation

@getfatday
Copy link

Description

Controllers are created in the order they are passed into the router controller options, not in the order they are registered with metadata

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

Fixes #774

@getfatday getfatday changed the title fix(controller): create controllers in specified order fix: create controllers in specified order Sep 16, 2021
@dantaeusb
Copy link

I faced the same problem that mentioned in #774 in a bit different manner.
I agree that import ordering in server bootstrap is counter-intuitive and hope this will be merged, or at least there'll be some explanation in docs for @Controller and @{Method} parametrized decorators.

@alexberriman
Copy link

+1 for this. Frustrating and counter intuitive.

@attilaorosz
Copy link
Member

This is reasonable and I agree with the solution, but this might be breaking for some people who rely solely on the workaround. @NoNameProvided thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants